chore: clean up Nextflow selector warnings and dead config#472
Open
m-huertasp wants to merge 17 commits into
Open
chore: clean up Nextflow selector warnings and dead config#472m-huertasp wants to merge 17 commits into
m-huertasp wants to merge 17 commits into
Conversation
- MUTRATE.*:MUTRATE* - OMEGA.*:ESTIMATOR_-* - OMEGA.*:(PREPROCESSING|ESTIMATOR).*
22 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy Nextflow runtime warnings by (1) pruning config selectors that no longer match any processes and (2) removing redundant .first() calls by pinning singleton channels at their sources (subworkflows / collectFile(...) outputs).
Changes:
- Remove an unused
CREATESAMPLEPANELSmodule and delete deadwithNameblocks targeting removed processes. - Simplify
withNameselectors (favoring module/process aliases) and document remaining expected selector warnings for param-gated features. - Pin singletons at source (e.g.,
collectFile(...).first(), subworkflow outputs) and drop downstream redundant.first()calls.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workflows/deepcsa.nf | Removes downstream .first() calls and pins a collectFile(...) result at the source to avoid “useless first” warnings. |
| subworkflows/local/omega/main.nf | Drops redundant .first() on a take: input when calling PREPROCESSINGGLOBALLOC. |
| subworkflows/local/mutationpreprocessing/main.nf | Removes .first() on SUMANNOTATION.out.tab to avoid redundant value-channel pinning. |
| subworkflows/local/enrichpanels/main.nf | Pins expanded panel outputs at the source and emits them without re-pinning. |
| modules/local/createpanels/sample/main.nf | Deletes an orphaned/unused module (CREATESAMPLEPANELS). |
| conf/tools/panels.config | Removes dead selectors and consolidates EXPANDREGIONS publishDir configuration under simplified selectors. |
| conf/tools/omega.config | Documents expected warnings for gated selectors and simplifies selector patterns to better match aliases. |
| conf/tmp_quick_fixes.config | Simplifies a selector; retains expected-warning documentation for gated features. |
| conf/modules.config | Removes dead selectors, simplifies selectors for gated features, and adjusts regressions selectors to match module aliases. |
| conf/exome.config | Removes dead selectors and simplifies OMEGA-related selector expressions. |
| conf/base.config | Removes dead selectors and simplifies selector expressions to reduce “no matching selector” warnings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
21
| withName: 'MUTATEDGENOMESFROMVAFAM' { | ||
| errorStrategy = 'ignore' | ||
| maxRetries = 1 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes accumulated Nextflow "no matching selector" warnings that appeared after recent feature additions deleted or renamed processes. The fix has two parts: stripping dead
withNameblocks for processes that no longer exist, and simplifying overly-qualified selector paths so they match the actual module names. Feature-gated processes (regressions, introns, non-prot) get explicit comments so the expected warning is documented rather than treated as a regression.Changes
withNameselectors for deleted processes:CREATESAMPLEPANELS,SUBSETPANEL,MUTRATE,SUBSETPILEUP,READSPOSBEDbase.config,exome.config,modules.config,panels.config(drop redundant namespace prefixes that no longer match)workflows/deepcsa.nfand subworkflows; remove redundant.first()callsWhat to review
Run in Seqera to make sure no errors are raised there.
There are still some warnings from selectors:
What I did to remove most of these "selector" warnings was to follow what is done in here. Basically, for those selectors that can be distinguished on their own, use only their name:
For these selectors that I couldn't use the explicit module name, it is because some logic is used to use specific subfolders based on the name (e.g. .INTRONS., etc) or because same module name is used (e.g.
BBGTOOLS:DEEPCSA:OMEGAMULTI:SITECOMPARISONandBBGTOOLS:DEEPCSA:OMEGA:SITECOMPARISONFor the
.first()redundant calls, I think I fix most of them. There are some missing related with theclonal_structureand theget_signaturesmodes that I couldn't find.Testing
Verified by running the pipeline. No functional behaviour change found.
closes #468