handle IOException in rename during CompactPersistentActionCache init - #30866
Open
dws wants to merge 1 commit into
Open
handle IOException in rename during CompactPersistentActionCache init#30866dws wants to merge 1 commit into
dws wants to merge 1 commit into
Conversation
I've observed Bazel 9 failing as follows:
ERROR: Couldn't create action cache: [unix_jni.cc:638] /tmp/.cache-bzlmod/bazel/_bazel_jenkins/output-base/action_cache -> /tmp/.cache-bzlmod/bazel/_bazel_jenkins/output-base/action_cache.bad (Invalid cross-device link). If error persists, use 'bazel clean'.
This unhandled IOException causes Bazel to fail to print the original
cause of the problem that drove it into `logAndThrowOrRecurse()`.
We here attempt to improve the reporting and allow Bazel to survive the problem.
github-actions
Bot
added
team-Performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've observed Bazel 9.2.0 failing as follows:
This unhandled
IOExceptioncauses Bazel to fail to print the original cause of the problem that drove it intologAndThrowOrRecurse().We here attempt to improve the reporting and allow Bazel to survive the problem.
Note that
renameCorruptedFiles()in Bazel 8 does handle and surviveIOException.Motivation
Since Bazel 8 was able to survive not being able to rename corrupted action cache files,
it seems like it would be a good idea for Bazel 9 to be able to do the same.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None