Expose LED switch to WebUI, prepare lighttpd proxy pass.#12
Open
thinksilicon wants to merge 1 commit into
Open
Expose LED switch to WebUI, prepare lighttpd proxy pass.#12thinksilicon wants to merge 1 commit into
thinksilicon wants to merge 1 commit into
Conversation
Owner
|
Appreciate the pull request. To be completely transparent, I don't plan on merging it. This is because the OliveTin implementation of this app has quite some limitations (as you found out) and I think it is not worth developing it further into the future. In other words, there will be no new 1.x releases. For that reason I've begun working on a rewrite, and the feature you've suggested/contributed will be part of that as well. I will leave this PR open for now, just in case it helps someone who's looking for this particular feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very small change just so you can switch the LED remotely. I was also looking into exposing OliveTin via lighttpd proxy pass, but turns out that's not as easy the way OliveTin works. The documentation is not overly straight forward if you want to use a subdirectory.
Maybe the LED switch alone is useful to someone.