feat(ColumnManager): add drag and drop feature - #128
Conversation
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (2)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
efc6c8b to
4327058
Compare
4327058 to
4e6cf08
Compare
| "@patternfly/patternfly": "^6.6.1", | ||
| "@patternfly/react-component-groups": "^6.5.0", | ||
| "@patternfly/react-core": "^6.6.1", | ||
| "@patternfly/react-table": "^6.6.1", |
There was a problem hiding this comment.
If these bumps are really necessary we should try to stick to the same version boundaries as the frontend-components[0] package has.
To have a version available in Storybook to test that supports the drag & drop it should only require updating the package-lock.json and leave the peerDependencies unchanged, so that when the tabletools package is installed/used it won't require a higher version, but still allow it.
[0] https://github.com/RedHatInsights/frontend-components/blob/master/package.json#L42-L46
There was a problem hiding this comment.
@bastilian gotcha! updated lock file and restored dependencies.
4e6cf08 to
a38cf37
Compare
bastilian
left a comment
There was a problem hiding this comment.
Awesome! Works like a charm! Thank you @LightOfHeaven1994!
a38cf37 to
e698a99
Compare

Can be tested with stroybook http://localhost:6006/?path=/story/tabletoolstable--with-column-drag-drop
https://www.patternfly.org/component-groups/helpers/column-management-modal#with-drag-and-drop-reordering
Closes #120