Skip to content

feat(ColumnManager): add drag and drop feature - #128

Merged
bastilian merged 1 commit into
mainfrom
feat/column-manager-drag-drop
Aug 10, 2026
Merged

feat(ColumnManager): add drag and drop feature#128
bastilian merged 1 commit into
mainfrom
feat/column-manager-drag-drop

Conversation

@LightOfHeaven1994

@LightOfHeaven1994 LightOfHeaven1994 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.7%.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: A
src/hooks/useColumnManager/useColumnManager.js100.0%
Coverage rating: A Coverage rating: A
src/hooks/useColumnManager/helper.js97.5%70
Total97.9%
🤖 Increase coverage with AI coding...
In the `feat/column-manager-drag-drop` branch, add test coverage for this new code:

- `src/hooks/useColumnManager/helper.js` -- Line 70

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

All good ✅

Comment thread src/hooks/useColumnManager/helper.js Outdated
Comment thread .storybook/preview-body.html Outdated
@LightOfHeaven1994
LightOfHeaven1994 force-pushed the feat/column-manager-drag-drop branch 4 times, most recently from efc6c8b to 4327058 Compare August 10, 2026 13:15
@bastilian
bastilian force-pushed the feat/column-manager-drag-drop branch from 4327058 to 4e6cf08 Compare August 10, 2026 17:36
Comment thread package.json Outdated
"@patternfly/patternfly": "^6.6.1",
"@patternfly/react-component-groups": "^6.5.0",
"@patternfly/react-core": "^6.6.1",
"@patternfly/react-table": "^6.6.1",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these bumps are really necessary we should try to stick to the same version boundaries as the frontend-components[0] package has.

To have a version available in Storybook to test that supports the drag & drop it should only require updating the package-lock.json and leave the peerDependencies unchanged, so that when the tabletools package is installed/used it won't require a higher version, but still allow it.

[0] https://github.com/RedHatInsights/frontend-components/blob/master/package.json#L42-L46

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bastilian gotcha! updated lock file and restored dependencies.

@LightOfHeaven1994
LightOfHeaven1994 force-pushed the feat/column-manager-drag-drop branch from 4e6cf08 to a38cf37 Compare August 10, 2026 18:15

@bastilian bastilian left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Works like a charm! Thank you @LightOfHeaven1994!

@bastilian
bastilian force-pushed the feat/column-manager-drag-drop branch from a38cf37 to e698a99 Compare August 10, 2026 18:32
@bastilian
bastilian merged commit 4a05035 into main Aug 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow enabling drag & drop of columns in ColumnManager modal

2 participants