Skip to content

fix(useExpandable): avoid showing checkbox on item details #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
LightOfHeaven1994 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(useExpandable): avoid showing checkbox on item details #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/hooks/useExpandable/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ import React from 'react';

const detailsRowForRule = (item, DetailsComponent, colSpan, runningIndex) => ({
parent: runningIndex() - 1,
props: {
...item.props,
'aria-setsize': 0,
},
props: (() => {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { 'aria-level': _ariaLevel, ...detailsRowProps } = item.props || {};

@bastilian bastilian May 29, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still first like to try and find out where we set the aria-level in the first place and not set it for the details row cases.

return {
...detailsRowProps,
'aria-setsize': 0,
};
})(),
cells: [
{
title: <DetailsComponent item={item} key={'item-' + item.rowId} />,
Expand Down
Loading