Skip to content

feat(workflows): prefix-cache prompt layout + warm-first fan-out (V3, #2493) - #2534

Merged
flora131 merged 4 commits into
mainfrom
verifier/prefix-cache-prompts
Aug 19, 2026
Merged

feat(workflows): prefix-cache prompt layout + warm-first fan-out (V3, #2493)#2534
flora131 merged 4 commits into
mainfrom
verifier/prefix-cache-prompts

Conversation

@flora131

@flora131 flora131 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Replacement for #2510 after the stacked-PR base branch was deleted. Same branch, now targeting main (V1 already merged).


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Greptile Summary

This change makes judge prompts reuse a cache-friendly prefix, keeps inline candidate content within UTF-8 byte limits, and prioritizes warm verifier work without changing result order. It also expands coverage for prompt layout, fallback boundaries, concurrency, ordering, and verifier failures.

One P2 repository-style issue remains in the new test: its assertion callback declares an overly broad unknown error parameter instead of the project-required specific error type.

Confidence Score: 4/5

The functional workflow changes are covered by focused tests; merge safety is reduced only by a non-security repository-style violation in the added test.

The final findings contain one non-security P2 issue and no P0 or P1 issues, which maps to a score of 4.

Files Needing Attention: test/unit/verification-prompt-layout.test.ts

Prompt To Fix All With AI
### Issue 1
test/unit/verification-prompt-layout.test.ts:128
**Ambiguous error parameter type**

The new assertion callback explicitly declares `error` as `unknown`, conflicting with the repository convention to use specific types and making the expected failure shape less explicit.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "merge origin/main" | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

Context used:

  • Context used - AGENTS.md (source)

@flora131
flora131 merged commit 33fdd7d into main Aug 19, 2026
15 checks passed
const output = await warm_first_fan_out(ctx, input, (step) => step.prompt, { warmConcurrency: 2 });
assert.deepEqual(calls, [
["a-1", "b-1"],
["a-2", "b-2"],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Ambiguous error parameter type

The new assertion callback explicitly declares error as unknown, conflicting with the repository convention to use specific types and making the expected failure shape less explicit.

Context Used: AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: test/unit/verification-prompt-layout.test.ts
Line: 128

Comment:
**Ambiguous error parameter type**

The new assertion callback explicitly declares `error` as `unknown`, conflicting with the repository convention to use specific types and making the expected failure shape less explicit.

**Context Used:** AGENTS.md ([source](https://github.com/bastani-inc/atomic/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant