feat(workflows): prefix-cache prompt layout + warm-first fan-out (V3, #2493) - #2534
Merged
Conversation
| const output = await warm_first_fan_out(ctx, input, (step) => step.prompt, { warmConcurrency: 2 }); | ||
| assert.deepEqual(calls, [ | ||
| ["a-1", "b-1"], | ||
| ["a-2", "b-2"], |
There was a problem hiding this comment.
Ambiguous error parameter type
The new assertion callback explicitly declares error as unknown, conflicting with the repository convention to use specific types and making the expected failure shape less explicit.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/unit/verification-prompt-layout.test.ts
Line: 128
Comment:
**Ambiguous error parameter type**
The new assertion callback explicitly declares `error` as `unknown`, conflicting with the repository convention to use specific types and making the expected failure shape less explicit.
**Context Used:** AGENTS.md ([source](https://github.com/bastani-inc/atomic/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for #2510 after the stacked-PR base branch was deleted. Same branch, now targeting main (V1 already merged).
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
This change makes judge prompts reuse a cache-friendly prefix, keeps inline candidate content within UTF-8 byte limits, and prioritizes warm verifier work without changing result order. It also expands coverage for prompt layout, fallback boundaries, concurrency, ordering, and verifier failures.
One P2 repository-style issue remains in the new test: its assertion callback declares an overly broad
unknownerror parameter instead of the project-required specific error type.Confidence Score: 4/5
The functional workflow changes are covered by focused tests; merge safety is reduced only by a non-security repository-style violation in the added test.
The final findings contain one non-security P2 issue and no P0 or P1 issues, which maps to a score of 4.
Files Needing Attention: test/unit/verification-prompt-layout.test.ts
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "merge origin/main" | Re-trigger Greptile
Context used: