docs(workflows): verification-scaling guidance for starter patterns (D1, #2491) - #2503
Conversation
Assistant-model: Grok 4.6
92cc989 to
c18caac
Compare
| | `adversarial-verification` | worker → fresh rubric verifiers → reducer → bounded repair; decompose rubrics into named criteria and aggregate by mean plus explicit veto, never a unanimity AND | `task`; `verifier_count=3`, `max_repairs=2` | result, approval, repairs, candidate/review/verifier paths | | ||
| | `generate-and-filter` | candidate fan-out → dedupe/filter → optional judge → shortlist; use graded per-criterion scores, Bradley–Terry preference from score gaps, and slot-swap repeats when ranking candidates | `prompt`; `num_candidates=8`, `shortlist_size=3`, `use_judge=true`, `max_concurrency=4` | result, shortlist and candidate/filter/judge/final/manifest paths | | ||
| | `tournament` | independent attempts → order-balanced pairwise judges → bracket reducer; derive a Bradley–Terry preference from graded score gaps and repeat with A/B slot swaps | `prompt`; `num_attempts=4`, `max_concurrency=4` | result, winner, attempt/judge/bracket paths | | ||
| | `loop-until-done` | durable ledger → iteration/evaluator loop → complete or inspectable exhaustion; record progress magnitude beside the stop bit and treat flat trend as stall evidence, never a kill switch | `prompt`; `max_iterations=5` | result/status, ledger, iteration/evaluation paths, remaining work | |
There was a problem hiding this comment.
Builtin behavior is overstated
The builtin table presents custom verification-scaling recommendations as behavior users receive from the shipped workflows. adversarial-verification still uses a unanimous binary verifier gate; generate-and-filter and tournament expose shortlist or binary-winner judging rather than graded Bradley–Terry scores with repeated slot swaps; and loop-until-done records a boolean completion decision without progress magnitude or trend tracking. A caller selecting these builtins therefore does not get the verification and convergence guarantees described here. Either implement these mechanisms or move the recommendations into custom-authoring guidance and describe the current builtin contracts.
Artifacts
README builtin workflow claims before validation
- Captured `HEAD` README lines 775-778 before running the builtin workflows, showing the four claimed mechanisms; takeaway: these are the assertions tested.
Executable builtin documentation validation script
- The authored TypeScript harness invokes all four builtin runners with deterministic stage responses and asserts their actual schemas and control paths; takeaway: it is the exact executable test source.
Executed builtin workflow behavior after validation
- Output of the executable harness showing a failed verifier blocked acceptance, shortlist and binary-winner schemas, three tournament judges, and no progress or trend fields; takeaway: every claimed behavior is contradicted at runtime.
Focused builtin regression test run
- Focused Vitest execution of the existing adversarial/generate and tournament/loop tests completed with 12 passing tests; takeaway: the observed legacy behavior is covered by the current tests.
Repository worktree check after validation
- Captured git status after validation showing no source edits from this review outside the required artifact directory and pre-existing Greptile metadata; takeaway: repository files were not modified.
Ran code and verified through T-Rex
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/workflows/README.md
Line: 775-778
Comment:
**Builtin behavior is overstated**
The builtin table presents custom verification-scaling recommendations as behavior users receive from the shipped workflows. `adversarial-verification` still uses a unanimous binary verifier gate; `generate-and-filter` and `tournament` expose shortlist or binary-winner judging rather than graded Bradley–Terry scores with repeated slot swaps; and `loop-until-done` records a boolean completion decision without progress magnitude or trend tracking. A caller selecting these builtins therefore does not get the verification and convergence guarantees described here. Either implement these mechanisms or move the recommendations into custom-authoring guidance and describe the current builtin contracts.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Evidence
Acceptance criteria (from #2491, D1 subset)
packages/workflows/README.md.83.1citation appears. Proven by the number audit and stranger review.Commands
Size
Docs-only slice; the source-line cap is exempt. The diff is limited to two allowed documentation files.
Spec
specs/2026-08-17-verifier-docs.md§3.1 (D1), §4.1, and §5; umbrellaspecs/2026-08-17-llm-verifier-adoption-program.md§5.3 Evidence protocol and §9 Q7. Number citations were checked againstresearch/docs/2026-08-17-llm-verifier-adoption-scan.md§3.Edited-section anchors
workflows.md— Adversarial verificationworkflows.md— Generate-and-filterworkflows.md— Tournamentworkflows.md— Loop until doneworkflows.md— Verification scalingREADME.md— Six composable pattern workflowsStranger test
Source given to the stranger: the edited Tournament section only.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Greptile Summary
This change adds verification-scaling guidance and expands the builtin workflow table. The table currently attributes mean-plus-veto aggregation, graded Bradley–Terry ranking with repeated slot swaps, and progress-trend tracking to shipped builtins that do not implement those mechanisms. Update
packages/workflows/README.mdto describe the current builtin contracts, or implement the described behavior before merging.Confidence Score: 4/5
Not safe to merge as written because the builtin workflow table promises behavior that differs from the shipped implementations.
An executable harness exercised the four documented workflow paths and directly observed the binary verifier, shortlist or binary-winner judge, knockout bracket, and boolean completion-ledger contracts. Focused regression tests also passed with those current contracts.
Files Needing Attention:
packages/workflows/README.mdlines 775-778 need to distinguish custom-authoring recommendations from currently shipped builtin behavior.What T-Rex did
Comments Outside Diff (1)
General comment
packages/workflows/README.md:775-778promises mean-plus-veto aggregation for adversarial verification; graded per-criterion Bradley–Terry scoring plus repeated A/B slot swaps for generate-and-filter and tournament; and progress-magnitude/trend tracking for loop-until-done. The shipped workflows instead use unanimous binary verifier verdicts, shortlist-only or binary-winner judge schemas, a single order-balanced knockout bracket, and a ledger containing only the booleandonedecision and textual evidence/findings. Therefore a user invoking every named builtin does not receive the documented behavior.Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "docs(workflows): give generate-and-filte..." | Re-trigger Greptile