This repository was archived by the owner on Jul 28, 2024. It is now read-only.
FireFox bug fixed#27
Open
MarkNijhof wants to merge 165 commits into
Open
Conversation
…ors, backgrounds, and alignment. Added getStyle to iFrame.js to retrieve a style specified within the iFrame. Added an unattach method to the iFrame so you can remove the editor. Tested the above in editor_test.js. Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
…tting Selection() methods, renamed past tests to Nested. The bug fix for firefox deals with backcolor and execCommand being handled differently in firefox than the other browsers (it uses hilitecolor). The bug fix for IE resolves an issue with losing its selection when clicking on the toolbar by saving its selection. Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
…he page Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
…as just... wrong. Signed-off-by: Joshua Peek <josh@joshpeek.com>
…as just... wrong. Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
Signed-off-by: Joshua Peek <josh@joshpeek.com>
…(like bold) that the use of the enter key while typing your text will active the button again instead of creating a newline. This fix will check for FireFox and if detected it will focus on the editor after the command is executed
…instead of manually parsing the userAgent myself
…them after clicking a second time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FireFox there is a bug that when you type and then click a button (like bold) that the use of the enter key while typing your text will active the button again instead of creating a newline. This fix will check for FireFox and if detected it will focus on the editor after the command is executed.
I tested this in FireFox (3.6.13), Safari (5.0.3) and Chrome (9.0.597.102 & 9.0.597.107 I got an update :)) I don't have IE nor other versions of the browsers. Also I was still unable to get the unit tests to run, so this is a very poor (but working) patch.
-Mark