Model the Imbox's Previously Seen postings: GetImboxSeen - #129
Merged
Conversation
GET /imbox/seen.json answers the box show shape with the Imbox's seen postings ordered by when they were seen, an ordering the Imbox's own pages do not offer. Its next_history_url names /imbox, but the page cursor inside it belongs to the seen ordering — extract the cursor and hand it back to GetImboxSeen, never to GetImbox.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`GET /imbox/seen.json` answers the box show shape with the Imbox's seen postings ordered by when they were seen — an ordering the Imbox's own pages do not offer, which is why the box cannot stand in for it.
One subtlety, noted on the wrapper: the response's `next_history_url` names `/imbox`, but the page cursor inside it belongs to the seen ordering. Extract the cursor and hand it back to `GetImboxSeen`, never to `GetImbox`.
Smithy model updated and regenerated (`make smithy-build`, `make go-generate`); the route comes off the excluded list. No drift, 126/126 coverage.
Needed by hey-cli's Previously Seen screen (the TUI's `9` shortcut, matching the web app).