Preserve configured senders across draft writes - #128
Open
jr-lillard wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds explicit sender preservation to draft creation, updates, sending, and reply drafts.
Changes:
- Adds
ActingSenderIDto draft content. - Adds
CreateReplyDraftWithSender. - Adds focused sender propagation tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
go/pkg/hey/messages.go |
Propagates explicitly selected senders through draft writes. |
go/pkg/hey/entries.go |
Adds sender-aware reply draft creation. |
go/pkg/hey/drafts_test.go |
Tests explicit sender propagation and validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateReplyDraftWithSenderwhile retaining the existing default-sender behavior for current callersTesting
mise exec -- make checkgo test -race -count=1 ./...GOTOOLCHAIN=go1.26.6 govulncheck ./...Summary by cubic
Preserves an explicitly selected sender across draft create, update, send, and reply-draft flows, instead of always falling back to the identity's default sender.
ActingSenderIDtoDraftContentfor message drafts; zero keeps the default-sender behavior.CreateReplyDraftWithSenderfor reply drafts while existing callers keep using the default sender.Looks good!
Written for commit baa9c85. Summary will update on new commits.