Skip to content

Preserve configured senders across draft writes - #128

Open
jr-lillard wants to merge 2 commits into
basecamp:mainfrom
jr-lillard:build/hey-sdk-sender-preservation-v0.27.0
Open

Preserve configured senders across draft writes#128
jr-lillard wants to merge 2 commits into
basecamp:mainfrom
jr-lillard:build/hey-sdk-sender-preservation-v0.27.0

Conversation

@jr-lillard

@jr-lillard jr-lillard commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • expose the optional acting sender ID on draft content
  • preserve an explicitly selected sender when creating, updating, and sending drafts
  • add CreateReplyDraftWithSender while retaining the existing default-sender behavior for current callers
  • cover create, update, send, and reply-draft sender propagation with focused tests

Testing

  • mise exec -- make check
  • go test -race -count=1 ./...
  • GOTOOLCHAIN=go1.26.6 govulncheck ./...

Summary by cubic

Preserves an explicitly selected sender across draft create, update, send, and reply-draft flows, instead of always falling back to the identity's default sender.

  • Adds ActingSenderID to DraftContent for message drafts; zero keeps the default-sender behavior.
  • Adds CreateReplyDraftWithSender for reply drafts while existing callers keep using the default sender.
  • Rejects negative acting sender IDs with a usage error on draft writes.

Looks good!

Written for commit baa9c85. Summary will update on new commits.

Review in cubic

Copilot AI balanced review requested due to automatic review settings August 26, 2026 14:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit sender preservation to draft creation, updates, sending, and reply drafts.

Changes:

  • Adds ActingSenderID to draft content.
  • Adds CreateReplyDraftWithSender.
  • Adds focused sender propagation tests.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
go/pkg/hey/messages.go Propagates explicitly selected senders through draft writes.
go/pkg/hey/entries.go Adds sender-aware reply draft creation.
go/pkg/hey/drafts_test.go Tests explicit sender propagation and validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread go/pkg/hey/messages.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants