Expose calendar recording pagination - #125
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds cursor-aware pagination for calendar recordings while preserving the existing single-page API.
Changes:
- Adds the
pagequery parameter and regenerates the Go client. - Introduces
GetRecordingsPagewithNextPage. - Adds unit and conformance coverage; bumps SDK to 0.25.0.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
spec/hey.smithy |
Models the optional page cursor. |
openapi.json |
Reflects the generated query parameter. |
go/pkg/generated/client.gen.go |
Serializes the page cursor. |
go/pkg/hey/calendars.go |
Adds the cursor-bearing page API. |
go/pkg/hey/services_test.go |
Tests cursor submission and extraction. |
conformance/tests/pagination.json |
Covers pagination request parameters. |
conformance/runner/go/main.go |
Supplies calendar query parameters. |
go/pkg/hey/version.go |
Bumps the SDK to 0.25.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calendar recording windows are geared-paginated, but the SDK discarded their
Linkcursor. This adds the cursor-bearing page API needed for callers to enumerate complete windows, including recurring series whose original start falls after the first page.API surface
pagequery parameter toGetCalendarRecordingsParams.CalendarRecordingsPageandCalendars().GetRecordingsPage.Calendars().GetRecordingssource-compatible and returning the requested page as before.Proof
Linkheader.make checkpasses: Go tests and lint are green, generated artifacts are current, and all 165 conformance cases pass.Risk and reviewer focus
Risk is low: the generated parameter and wrapper are additive, and existing
GetRecordingscallers retain one-page behavior. Please focus on the page wrapper contract and preservation of the existing method.Consumer
basecamp/hey-cli#332 follows complete event, to-do, and journal windows with this page API. The original bug report was supplied out-of-band, so there is no durable issue link.