Render nested Action Text attachment content - #335
Open
nitrnitr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renders unnamed nested Action Text attachment HTML through the existing bounded Markdown path while preserving named file attachments.
Changes:
- Added nested attachment-content rendering.
- Added regression and filename-precedence tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/htmlutil/markdown.go |
Handles embedded Action Text attachment content. |
internal/htmlutil/markdown_test.go |
Tests nested HTML and filename precedence. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nitrnitr
force-pushed
the
fix/nested-action-text-attachment-content
branch
from
August 26, 2026 01:56
2b6d4f3 to
f33596e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Handle bare
<action-text-attachment>elements whose HTML is stored in acontentattribute.HEY can nest this element inside a Trix HTML attachment. Previously,
ToMarkdowntreated it as a file attachment and rendered📎 attachment, dropping the embedded text and links.Unnamed elements with non-empty
contentare now rendered through the existing bounded embedded-HTML path. Named elements remain file attachments.Added regression coverage for both the nested HTML case and filename precedence.
Testing
make checkmake build