Fix: Remove sensitive payload logging and surface SPL resolution errors - #5
Open
mertcano wants to merge 1 commit into
Open
Fix: Remove sensitive payload logging and surface SPL resolution errors#5mertcano wants to merge 1 commit into
mertcano wants to merge 1 commit into
Conversation
### Description
This PR addresses observability gaps and sensitive data exposure within the `bridge-explorer` repository.
**Vulnerabilities & Security Defects Remediated:**
* **Sensitive Logging (`src/lib/solana.ts`):** Production `console.log` calls previously emitted raw Solana transaction objects, account data, signature lists, and token metadata payloads. These overly verbose logs have been completely removed to prevent sensitive payload exposure in production environments.
* **Observability and Error Propagation (`src/lib/solana.ts`):** The `getSplData` function previously attempted to read token metadata using empty `catch {}` blocks, which silently discarded underlying failures and resulted in "unknown" token data. The implementation has been refactored to reuse a single connection and iterate through supported token programs. It now properly retains the last error and throws a contextual exception (`Unable to resolve SPL data for <token>`) with the original error attached as the cause, ensuring failures are safely observable.
|
@mertcano is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses observability gaps and sensitive data exposure within the
bridge-explorerrepository.Vulnerabilities & Security Defects Remediated:
src/lib/solana.ts): Productionconsole.logcalls previously emitted raw Solana transaction objects, account data, signature lists, and token metadata payloads. These overly verbose logs have been completely removed to prevent sensitive payload exposure in production environments.src/lib/solana.ts): ThegetSplDatafunction previously attempted to read token metadata using emptycatch {}blocks, which silently discarded underlying failures and resulted in "unknown" token data. The implementation has been refactored to reuse a single connection and iterate through supported token programs. It now properly retains the last error and throws a contextual exception (Unable to resolve SPL data for <token>) with the original error attached as the cause, ensuring failures are safely observable.