Skip to content

chore: address informative security considerations - #14

Merged
mialbu merged 4 commits into
mainfrom
chore/xgas-03-considerations
May 20, 2026
Merged

chore: address informative security considerations#14
mialbu merged 4 commits into
mainfrom
chore/xgas-03-considerations

Conversation

@mialbu

@mialbu mialbu commented May 13, 2026

Copy link
Copy Markdown
Member

Summary

Addresses the informative audit findings (XGAS-03).

Adds security and integration guidance for:

  • absence of emergency pause / kill-switch controls as an intentional immutable/no-admin design choice;
  • possible forced GAS surplus where address(this).balance > totalSupply();
  • standard ERC-20 approval race behavior and recommended approval patterns;
  • Git submodule dependency and review expectations.

The update also clarifies the repository’s Git submodule model and dependency review workflow, including the role of superproject gitlink SHAs and reproducible submodule checkout behavior.

Notes

No production Solidity behavior was changed.

@mialbu
mialbu requested a review from merl111 May 13, 2026 17:00
@mialbu
mialbu merged commit 3d472e9 into main May 20, 2026
2 checks passed
@mialbu
mialbu deleted the chore/xgas-03-considerations branch May 20, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants