chore: address XGAS-01 signature validation semantics - #13
Merged
Conversation
Add SignatureValidationSemantics tests and architecture notes for encoded-signature validation behavior. - add EOA and ERC-1271 encoded-path success tests - add EIP-7702-style code-presence regression showing encoded-path rejection while classic (v,r,s) still succeeds - document SignatureChecker routing, implications, and integration guidance
Member
Author
merl111
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses XGAS-01 (#10)
Documents and tests the EIP-7702-related validation semantics of xGAS bytes-signature entrypoints that use
SignatureChecker.isValidSignatureNow.The update clarifies that bytes-signature paths intentionally follow the signer account’s current validation mode, including ERC-1271 validation when the signer has code. It also adds tests proving the distinction between encoded-signature paths and classic EIP-3009
(v, r, s)paths.Changes
(v, r, s)paths continue to use direct ECDSA validation.Notes
No production validation logic was changed. The PR documents and tests the intended design behavior.