Skip to content

fix: pair permissions and hide self-reporting ACP tools#423

Closed
AlexanderZ-Band wants to merge 1 commit into
devfrom
int-1005-acp-client-orphaned-permission-request-tool_call-reply
Closed

fix: pair permissions and hide self-reporting ACP tools#423
AlexanderZ-Band wants to merge 1 commit into
devfrom
int-1005-acp-client-orphaned-permission-request-tool_call-reply

Conversation

@AlexanderZ-Band

@AlexanderZ-Band AlexanderZ-Band commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes ACP room transcript handling for permission requests and self-reporting Band tools.

  • Permission requests now emit matched tool_call and tool_result events with a shared call ID and explicit outcome.
  • ACP narration for self-reporting Band tools (band_send_message, band_send_event, and standalone MCP message names) is suppressed so visible room output is not duplicated or ordered after its own reply.
  • Adds shared name matching and deterministic ACP/MCP behavior coverage.

Validation

  • Ruff check: passed
  • Pyrefly check: 0 errors
  • ACP and runtime-focused tests: 350 passed
  • Full unit suite (rebased onto current dev): 3811 passed

@linear-code

linear-code Bot commented Jul 12, 2026

Copy link
Copy Markdown

INT-1005

@AlexanderZ-Band AlexanderZ-Band changed the title test(acp): reproduce permission and transcript ordering fix(integrations): pair permissions and hide self-reporting ACP tools Jul 12, 2026
@AlexanderZ-Band AlexanderZ-Band changed the title fix(integrations): pair permissions and hide self-reporting ACP tools fix: pair permissions and hide self-reporting ACP tools Jul 12, 2026
@AlexanderZ-Band AlexanderZ-Band requested a review from a team July 12, 2026 17:33
@AlexanderZ-Band AlexanderZ-Band force-pushed the int-1005-acp-client-orphaned-permission-request-tool_call-reply branch from 8b63023 to 94a2be0 Compare July 14, 2026 10:54
Permission requests now emit matched tool_call and tool_result events
with a shared call ID and explicit outcome. ACP narration for
self-reporting Band tools (band_send_message, band_send_event, and
standalone MCP message names) is suppressed so visible room output is
not duplicated or ordered after its own reply.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@AlexanderZ-Band AlexanderZ-Band force-pushed the int-1005-acp-client-orphaned-permission-request-tool_call-reply branch from 94a2be0 to 34721d3 Compare July 14, 2026 14:00
@AlexanderZ-Band

Copy link
Copy Markdown
Collaborator Author

Superseded by #439, which combines this with #437 into a single PR against dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant