Skip to content

fix: remove explicit check of frequency equality - is already done by converting points #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matosys merged 1 commit into from
Feb 22, 2026
Merged

fix: remove explicit check of frequency equality - is already done by converting points #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/balderhub/waveform/lib/utils/waveforms/base_periodic_waveform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,6 @@ def compare(
max_allowed_rmse=max_allowed_rmse,
ignore_phase=ignore_phase
)
# have the same type -> compare each other directly
if self.frequency_hz != with_waveform.frequency_hz:
return False

if ignore_phase:
return self.get_phase_difference_to(with_waveform, max_allowed_rmse=max_allowed_rmse) is not None
Expand All @@ -172,6 +169,9 @@ def compare(
self_signal = self.get_resampled_version(common_delta_time).get_data_in_volts()
other_signal = with_waveform.get_resampled_version(common_delta_time).get_data_in_volts()

if len(self_signal) != len(other_signal):
return False

rmse = np.sqrt(np.mean((self_signal - other_signal) ** 2))
return rmse < max_allowed_rmse

Expand Down