QC automation - #370
Merged
Merged
Conversation
johnlees
requested changes
Feb 3, 2026
johnlees
left a comment
johnlees
left a comment
Member
There was a problem hiding this comment.
Thanks Anlei, a few small changes to make
Can you also update the QC page in the docs/ to add information on how to use this mode and what it does? You could even add a couple of your plots of the distances as before/after
johnlees
reviewed
Feb 9, 2026
|
|
||
| Before QC: | ||
|
|
||
| .. image:: images/s.pneumoniae_5k_db_distanceDistribution.png |
Member
There was a problem hiding this comment.
I think you haven't committed this image to the repo
johnlees
reviewed
Feb 9, 2026
|
|
||
| Done | ||
|
|
||
| .. image:: images/s.pneumoniae_5k_qc_default_distanceDistribution.png |
johnlees
approved these changes
Feb 9, 2026
johnlees
left a comment
johnlees
left a comment
Member
There was a problem hiding this comment.
Add the missing docs images, then should be good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added automatic maximum distance determination into QC, as an alternative to user-defined max-pi-dist and max-a-dist.