fix: keep ADS handles alive and update on_init signature - #8
Open
mfabregat wants to merge 1 commit into
Open
Conversation
Retain ADS handle objects to avoid invalid handles during sum read/write, and adopt the new HardwareComponentInterfaceParams on_init API to silence Jazzy deprecation warnings
|
@Nibanovic @habartakh Please take a look at this PR. |
Contributor
|
Ah, so if I understood, when we destroy the handle on our side, PLC is signaled to clear the handle. Then when we make a SUM read command, it says "I don't have this" and rejects the request. SO we can use the derefrenced |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retain ADS handle objects to avoid invalid handles during sum read/write, and adopt the new HardwareComponentInterfaceParams on_init API to silence Jazzy deprecation warnings