ci: re-add macos-latest build matrix and fix flaky mount timeout#165
Merged
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds the
macos-latestjob to the build matrix (removed inno macosi) and makes it pass.The only thing failing on macOS was the VFS
Teststep: all 17 failures were the same assertion instart_virtual_fs, which waited at most 2s for the FUSE mount to become visible. macFUSE consistently takes just over 2s to mount (CI showed 2.0–2.17s), so every VFS test trippedassert diff < 2, "timed out waiting for vfs to mount". Linux mounts in ~100ms and was unaffected.Fix is to raise that wait budget:
Workflow change re-introduces the matrix and the macFUSE install step:
fail-fast: falseso a failure on one OS doesn't cancel the other.Link to Devin session: https://app.devin.ai/sessions/5f1b65c493c34e64ab1e1d49ed52f5c1
Requested by: @azuline