Skip to content

Switch edit_release to read from tags instead of cache (#45)#163

Open
devin-ai-integration[bot] wants to merge 4 commits into
masterfrom
devin/1784153649-edit-release-from-tags
Open

Switch edit_release to read from tags instead of cache (#45)#163
devin-ai-integration[bot] wants to merge 4 commits into
masterfrom
devin/1784153649-edit-release-from-tags

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #45.

edit_release previously built the editable TOML via MetadataRelease.from_cache(release, tracks), presenting the readonly cache's derived view in the write path. It now reads AudioTags.from_file for each track and builds the TOML with a new MetadataRelease.from_audiotags(release, tracks, audiotags):

  • Release-level audio fields (title, releasetype, dates, edition, catalognumber, labels, genres, secondary genres, descriptors, release artists) come from the first track's AudioTags — consistent with how the cache derives release-level tags from the first track.
  • Per-track fields (discnumber, tracknumber, title, artists) come from each track's AudioTags.
  • new, favorite, and rating remain sourced from the cached Release, since they live in the .rose.{id}.toml datafile rather than audio tags.

from_cache had no other callers and is removed. The initial update_cache_for_releases call is kept so source paths stay fresh.

Adds a regression test asserting the editable TOML reflects on-disk tag changes even when the cache update is a no-op.

Link to Devin session: https://app.devin.ai/sessions/e54bb0f1aadc4db994169ae3e8e14cba
Requested by: @azuline


Open in Devin Review

@azuline azuline self-assigned this Jul 15, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch edit_release to read from tags instead of cache

1 participant