Switch edit_release to read from tags instead of cache (#45)#163
Open
devin-ai-integration[bot] wants to merge 4 commits into
Open
Switch edit_release to read from tags instead of cache (#45)#163devin-ai-integration[bot] wants to merge 4 commits into
devin-ai-integration[bot] wants to merge 4 commits into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #45.
edit_releasepreviously built the editable TOML viaMetadataRelease.from_cache(release, tracks), presenting the readonly cache's derived view in the write path. It now readsAudioTags.from_filefor each track and builds the TOML with a newMetadataRelease.from_audiotags(release, tracks, audiotags):AudioTags— consistent with how the cache derives release-level tags from the first track.AudioTags.new,favorite, andratingremain sourced from the cachedRelease, since they live in the.rose.{id}.tomldatafile rather than audio tags.from_cachehad no other callers and is removed. The initialupdate_cache_for_releasescall is kept so source paths stay fresh.Adds a regression test asserting the editable TOML reflects on-disk tag changes even when the cache update is a no-op.
Link to Devin session: https://app.devin.ai/sessions/e54bb0f1aadc4db994169ae3e8e14cba
Requested by: @azuline