Skip to content

Bug fix for step time #479

Open
NRauschmayr wants to merge 1 commit intomasterfrom
fix_steptime
Open

Bug fix for step time #479
NRauschmayr wants to merge 1 commit intomasterfrom
fix_steptime

Conversation

@NRauschmayr
Copy link
Copy Markdown
Contributor

Description of changes:

I fixed the step time in PyTorch hook. It was only measuring the forward pass time.

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 8, 2021

Codecov Report

Merging #479 (23e80c8) into master (a7c697f) will decrease coverage by 0.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   66.88%   66.23%   -0.65%     
==========================================
  Files         173      163      -10     
  Lines       13280    12937     -343     
==========================================
- Hits         8882     8569     -313     
+ Misses       4398     4368      -30     
Impacted Files Coverage Δ
smdebug/pytorch/hook.py 75.07% <100.00%> (-1.00%) ⬇️
smdebug/core/modes.py 55.00% <0.00%> (-20.00%) ⬇️
smdebug/xgboost/singleton_utils.py 0.00% <0.00%> (-20.00%) ⬇️
smdebug/trials/profiler_trial.py 24.61% <0.00%> (-18.47%) ⬇️
smdebug/mxnet/collection.py 73.33% <0.00%> (-16.67%) ⬇️
smdebug/exceptions.py 65.47% <0.00%> (-15.48%) ⬇️
smdebug/core/reduction_config.py 88.31% <0.00%> (-7.80%) ⬇️
smdebug/core/reader.py 85.18% <0.00%> (-7.41%) ⬇️
smdebug/tensorflow/callable_cache.py 82.60% <0.00%> (-6.53%) ⬇️
smdebug/core/singleton_utils.py 85.29% <0.00%> (-5.89%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c697f...23e80c8. Read the comment docs.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.23%. Comparing base (a7c697f) to head (23e80c8).
⚠️ Report is 112 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   67.06%   66.23%   -0.83%     
==========================================
  Files         173      163      -10     
  Lines       13280    12937     -343     
==========================================
- Hits         8906     8569     -337     
+ Misses       4374     4368       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants