fix(walkthrough): update help link for LocalStack - #8802
Open
gtsiolis wants to merge 1 commit into
Open
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Author
|
@valerena since you added the original LocalStack walkthrough, could you or someone from the team take a look? 😁 Cc @laileni-aws because of #8229 |
gtsiolis
force-pushed
the
gt/update-walkthrough-help-link
branch
from
July 23, 2026 12:34
27325a3 to
811d779
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Application Builder walkthrough ("Complete installation" step), the LocalStack Learn more link renders as raw markdown text instead of a clickable link:
The link target has a doubled opening parenthesis
((, which breaks VS Code's markdown rendering. The Finch entry just below renders correctly, so the two optional-tool entries look inconsistent and the LocalStack docs are unreachable.This affects the macOS/Linux variant of
AWS.toolkit.lambda.walkthrough.toolInstall.description; the.windowsvariant was already correct.Solution
(so the LocalStack link renders as a clickable Learn more.Applied to both the default and
.windowsvariants inpackages/core/package.nls.json. Thepackages/toolkit/copies aregenerated from this file at build time (
copyFiles), so no manual edits there.Before / After
feature/xbranches will not be squash-merged at release time.