fix: bootstrap fails if bucket, ECR repo already exist#1544
Merged
Conversation
If a bootstrap stack is deleted, for safety it leaves behind the S3 Bucket and ECR repository used for storing assets. This will interfere with re-bootstrapping. Fortunately CloudFormation has an option to automatically adopt hard-named resources into a new stack, so we turn that on by default for bootstrapping. This will get rid of those errors. The chances this will interfere with normal operation is minimal, but on the off chance it does this behavior can be switched off with a `--no-import-existing-resources` flag.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 88.18% 88.16% -0.02%
==========================================
Files 76 76
Lines 10839 10841 +2
Branches 1493 1494 +1
==========================================
Hits 9558 9558
- Misses 1253 1255 +2
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrgrain
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a bootstrap stack is deleted, for safety it leaves behind the S3 Bucket and ECR repository used for storing assets. This will interfere with re-bootstrapping.
Fortunately CloudFormation has an option to automatically adopt hard-named resources into a new stack, so we turn that on by default for bootstrapping. This will get rid of those errors.
The chances this will interfere with normal operation is minimal, but on the off chance it does this behavior can be switched off with a
--no-import-existing-resourcesflag.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license