Skip to content

oneclick-stepfunction-human-approval#401

Closed
YogeshNain2015 wants to merge 1 commit into
aws-samples:mainfrom
YogeshNain2015:YogeshNain2015-feature-oneclick-stepfunction-human-approval
Closed

oneclick-stepfunction-human-approval#401
YogeshNain2015 wants to merge 1 commit into
aws-samples:mainfrom
YogeshNain2015:YogeshNain2015-feature-oneclick-stepfunction-human-approval

Conversation

@YogeshNain2015

Copy link
Copy Markdown

Issue #, if available: Issue: aws-samples/serverless-patterns#2796
as discussed from biswanath creating the issue here:
aws-samples/serverless-patterns#2795
its not duplicate,

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@YogeshNain2015

Copy link
Copy Markdown
Author

Just to add to pointer....
https://github.com/aws-samples/step-functions-workflows-collection/tree/main/parallel-human-approval
above github flow is different from mine reason:

  1. My flow will present user with SNS mail that display a one click workflow reject or approval link
    it envolves --> lambda--> SNS (API GW link of approval or denial ) --> requester click on approve or deny
  2. The existing one send the token in the mail and thats not useful until some make the api call to SFN to approve it.
  3. I have worked on Ent cx and already shared this solun which they liked.
image (1)

@YogeshNain2015

Copy link
Copy Markdown
Author

#402
created issue in stepfunction workflow as well.

@bfreiberg

Copy link
Copy Markdown
Contributor

Hi @YogeshNain2015 , thanks for your submission. We already have a very similar workflow on the site (https://serverlessland.com/workflows/human-in-the-loop). I suggest that you update the existing one with your enhancements like generating URLs for convenience.

@YogeshNain2015

YogeshNain2015 commented Aug 25, 2025

Copy link
Copy Markdown
Author

hi @bfreiberg
thank you for looking into the issue. Let me share my additional view on the workflow

  • the current workflow can't be updated since it it directly using SNS(with this we will only get the task token but we need to url encode it else due to characters in token the api call fails at api end.)
  • so the whole project will change in this case

additionally, i am not using SNS instead using lambda to wait for task token and url encoding it before sending as email.

what i am trying to convey is that my SFN workflow is different than the existing one, if i need to change it, then it will be changed entirely.

julianwood pushed a commit that referenced this pull request Jun 2, 2026
Replace the direct SNS waitForTaskToken integration with a Lambda-based
approach that URL-encodes the task token and sends clickable approve/reject
links via email. This eliminates the need for reviewers to manually copy
task tokens and use the AWS CLI.

Changes:
- Add SendApprovalEmailFunction (Python) that URL-encodes the task token
  and publishes an email with approve/reject links via SNS
- Add HandleApprovalFunction (Python) that decodes the token and calls
  SendTaskSuccess to resume the workflow
- Add API Gateway endpoint to handle the approval callback
- Update state machine to use lambda:invoke.waitForTaskToken
- Add architecture diagram (SVG) with official AWS icons
- Update README and example-workflow.json

From #401
@YogeshNain2015

Copy link
Copy Markdown
Author

made changes in https://serverlessland.com/workflows/human-in-the-loop as improvement so closing this one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants