fix: alias permissions silently dropped when statementID is nil#216
Open
michaelhtm wants to merge 2 commits into
Open
fix: alias permissions silently dropped when statementID is nil#216michaelhtm wants to merge 2 commits into
michaelhtm wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Validate that all permissions have a statementID before syncing, returning a terminal error if any are missing. Previously these were silently skipped, giving no feedback to the user.
michaelhtm
force-pushed
the
fix/alias-permissions-nil-statement-id
branch
from
e77c2f5 to
1202f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2659
Description of changes:
Permissions with nil statementID were excluded from comparison maps
and skipped during sync. Now they flow through to the AWS API which
returns the proper validation error.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.