feat: add task-role-arn and execution-role-arn inputs#475
Merged
Conversation
Allow users to dynamically set taskRoleArn and executionRoleArn on the task definition via action inputs, so role ARNs don't need to be hardcoded in the task definition JSON file. Includes ARN format validation supporting all AWS partitions (aws, aws-cn, aws-us-gov, aws-iso, aws-iso-b, aws-iso-e, aws-iso-f). Closes #378, closes #183 Co-authored-by: Marián Skrip <17459600+mskrip@users.noreply.github.com> Co-authored-by: Evan <26677092+DMEvanCT@users.noreply.github.com>
56e81f0 to
532ba07
Compare
amazreech
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task-role-arnandexecution-role-arnoptional inputs to dynamically settaskRoleArnandexecutionRoleArnon the rendered task definitionaws,aws-cn,aws-us-gov,aws-iso,aws-iso-b,aws-iso-e,aws-iso-fCloses #378, closes #183
Motivation
Users need to pass IAM role ARNs via GitHub Secrets rather than hardcoding them in task definition JSON files (security concern raised in #183). This also addresses the review feedback on PR #372 which requested ARN validation.
Test plan
getInputcalls/path/to/role)aws-cnpartition ARNnpm testpasses locallynpm run packagerebuilds dist/ cleanly