Fix extraction of tarballs in py3.14#6304
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements extraction_filter support for archive extraction to align with Python 3.12 security features. The review feedback suggests restricting the filter application to tar archives to avoid compatibility issues with zip files and removing a redundant attribute assignment in the uncompress function that is already handled by the extract method.
d18989d to
98d6104
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6304 +/- ##
==========================================
+ Coverage 72.05% 72.06% +0.01%
==========================================
Files 206 206
Lines 23349 23351 +2
==========================================
+ Hits 16825 16829 +4
+ Misses 6524 6522 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
any thoughts on this at all, as we're facing this issue in our pipelines, and could really do with getting this resolved |
|
LGTM. The code change looks good. The RTD docs CI failure is unrelated to your change — your branch predates a setuptools <82 pin we merged to master in March ( |
Use fully_trusted_filter for extraction to restore previous method Closes: avocado-framework#6302 Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
98d6104 to
da48a5f
Compare
|
Hi @arif-ali this looks good to me too. Did you make sure to rebase on the most recent master branch? Because looking at the rawhide error it still seems to be related to the setuptools to me. |
Use fully_trusted_filter for extraction to restore previous method
Closes: #6302