Skip to content

Fix extraction of tarballs in py3.14#6304

Open
arif-ali wants to merge 1 commit into
avocado-framework:masterfrom
arif-ali:avocado-arif-py314-extract-trusted
Open

Fix extraction of tarballs in py3.14#6304
arif-ali wants to merge 1 commit into
avocado-framework:masterfrom
arif-ali:avocado-arif-py314-extract-trusted

Conversation

@arif-ali

@arif-ali arif-ali commented May 6, 2026

Copy link
Copy Markdown
Contributor

Use fully_trusted_filter for extraction to restore previous method

Closes: #6302

@mr-avocado mr-avocado Bot moved this to Review Requested in Default project May 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements extraction_filter support for archive extraction to align with Python 3.12 security features. The review feedback suggests restricting the filter application to tar archives to avoid compatibility issues with zip files and removing a redundant attribute assignment in the uncompress function that is already handled by the extract method.

Comment thread avocado/utils/archive.py Outdated
Comment thread avocado/utils/archive.py Outdated
@arif-ali arif-ali force-pushed the avocado-arif-py314-extract-trusted branch from d18989d to 98d6104 Compare May 6, 2026 11:05
@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.06%. Comparing base (844aae0) to head (da48a5f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6304      +/-   ##
==========================================
+ Coverage   72.05%   72.06%   +0.01%     
==========================================
  Files         206      206              
  Lines       23349    23351       +2     
==========================================
+ Hits        16825    16829       +4     
+ Misses       6524     6522       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arif-ali

Copy link
Copy Markdown
Contributor Author

any thoughts on this at all, as we're facing this issue in our pipelines, and could really do with getting this resolved

@harvey0100

Copy link
Copy Markdown
Contributor

LGTM. The code change looks good.

The RTD docs CI failure is unrelated to your change — your branch predates a setuptools <82 pin we merged to master in March (requirements-doc.txt). Could you please rebase on current master? That will pick up the fix and the RTD check should pass.

Use fully_trusted_filter for extraction to restore previous method

Closes: avocado-framework#6302

Signed-off-by: Arif Ali <arif-ali@ubuntu.com>
@arif-ali arif-ali force-pushed the avocado-arif-py314-extract-trusted branch from 98d6104 to da48a5f Compare June 4, 2026 12:34
@pevogam

pevogam commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Hi @arif-ali this looks good to me too. Did you make sure to rebase on the most recent master branch? Because looking at the rawhide error it still seems to be related to the setuptools to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review Requested

Development

Successfully merging this pull request may close these issues.

the extract() function in tarball has changed in python3.14 and causes issues in avocado

3 participants