Close the model settings dialog once a save works - #181
Merged
Conversation
The dialog stayed open behind a Saved. line, so every save ended with a second click on the close button. A save that fails still keeps it open, because the message on it is the only place the reason is said. Claude-Session: https://claude.ai/code/session_01PG2vuux5tMsjnZBLWJzMyp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving in the model settings dialog left it open behind a
Saved.line, so every save needed a second click on the close button.Now a successful save closes it. A failed save keeps it open, because the message on it is the only place the reason is said.
Two lines in
saveSettings. No test:main.tshas no unit harness, and the success branch is structurally the statement after the awaited PUT resolves.https://claude.ai/code/session_01PG2vuux5tMsjnZBLWJzMyp