Fixes and improvements - #117
Merged
Merged
Conversation
Replaces 7zip with regular zip so it can be done within the container.
Since the sysmodule rework (a457636), the AVI infoframe was updated when applying the internal profile, and never for the external one, inverting the pre-rework behavior. The color quantization range of the external profile is now honored again, and the infoframe is left alone when applying/disabling internal corrections.
With dimming_timeout set to 0, the transition thread considered dimming overdue whenever no input activity occurred for over a second, and recalculated/reapplied the whole configuration on every 100ms tick until the next input. Mirror the timeout check already done in should_dim().
The CMU reset detection only skipped polling when both display clocks were gated, but reads the registers of a single head, selected by the current operation mode. When undocking while a button is held down, the operation mode change notification is delayed, so the poll kept targeting DISPLAY_B after the undock had already gated the DISP2 clock (DISP1 kept the check passing). MMIO reads to a clock-gated module stall the bus transaction, hanging core 3 until the clock is re-enabled by docking again, or a reboot. Check the clock of the specific head being polled instead.
averne
approved these changes
Aug 7, 2026
| all: $(MODULES) | ||
| @: | ||
|
|
||
| dist: $(DIST_TARGET) |
Owner
There was a problem hiding this comment.
Can you please restore this target? It avoids rebuilding the zip if it's already up to date.
Contributor
Author
There was a problem hiding this comment.
The reason I changed that is because the dist target gets cached, and as long as the name remains the same (as is xxx-dirty), it will not be rebuilt even if the underlying source changes. I got bitten by that myself. Alternatively we can do something like:
DIST_INPUTS = application/out/Fizeau.nro \
overlay/out/Fizeau.ovl \
sysmodule/out/Fizeau.nsp \
sysmodule/toolbox.json \
misc/default.ini \
$(wildcard misc/patches/*.ips)
dist: all
@$(MAKE) -s $(DIST_TARGET) --no-print-directory
$(DIST_TARGET): $(DIST_INPUTS)Let me know what you prefer.
Owner
There was a problem hiding this comment.
Ah true, there aren't any deps specified. I guess in this case it can be left as is, thanks for the explanation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on #104, but also found some additional issues along the way. Full change list:
Each change has detailed explanation in its corresponding commit. @averne