common: fix pointer-before-start UB in drop_incomplete_utf8#916
Open
dxbjavid wants to merge 1 commit into
Open
common: fix pointer-before-start UB in drop_incomplete_utf8#916dxbjavid wants to merge 1 commit into
dxbjavid wants to merge 1 commit into
Conversation
drop_incomplete_utf8() computes strchr(c, 0) - 1, which is undefined
when c is empty. The empty case is reached from
avahi_alternative_service_name(" #N") and avahi_alternative_host_name("-N")
via avahi_strndup(s, 0); fuzz-domain exercises both entry points.
Collaborator
|
As mentioned in another PR one-off fixes with no tests aren't considered especially in cases like this where tests are straightforward. I'll keep it open as a bug report though. Generally it would probably be better to open issues first and mention how issues are discovered along with all the details like the tooling, *san/Valgrind backtraces, the output of static analyzers and their names or anything like that. I'll also point to https://github.com/avahi/avahi/blob/master/.github/CONTRIBUTING.md again
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop_incomplete_utf8() computes
strchr(c, 0) - 1, which is undefinedwhen c is empty. The empty case is reached from
avahi_alternative_service_name(" #N") and avahi_alternative_host_name("-N")
via avahi_strndup(s, 0); fuzz-domain exercises both entry points.