ISSUE-783 # Remove WireMock feature (dependency, code, tests)#785
Open
devmaiter wants to merge 1 commit into
Open
ISSUE-783 # Remove WireMock feature (dependency, code, tests)#785devmaiter wants to merge 1 commit into
devmaiter wants to merge 1 commit into
Conversation
Owner
|
@devmaiter , CI build is in-progress here, let's have a look for the Green status, then review and merge the PR(785). |
Collaborator
Got a red 🔴 build and given a rerun. Can you keep an eye ? |
Author
|
Thanks for the rerun! The build is green now — all 5 Java matrix builds passed on attempt 3. Looks like the red was a transient failure. Ready for review whenever you are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove WireMock feature (dependency, code, tests)
Fixed Which Issue?
PR Branch
https://github.com/devmaiter/zerocode/tree/issue-783-remove-wiremock
Motivation and Context
As discussed in #783, this removes the WireMock integration (Maven dependency, code paths, tests and fixtures) from
master, mirroring what was already done on thejava17branch (commit 51120fb, PR #752) but excluding the Java 17-specific changes.Scope of the removal:
pom.xml(root),core/pom.xml,junit5-testing-examples/pom.xml:com.github.tomakehurst:wiremockdependency andwiremock.versionproperty removed. Same cleanup applied to thepom_OSSRH_NOTINUSE.xmlfiles and the WireMock mention inCI.md.RestEndPointMocker: WireMock code paths removed (the Virtuoso mock strategy is untouched).HttpApiExecutorImpl,MockStep,ZeroCodeMultiStepsScenarioRunnerImpl: WireMock branches removed.HandlebarsLocalDateHelper,ZeroCodeWireMockRunnerand all WireMock-only tests/fixtures deleted (RestEndPointMockerTest,MockStepTest, WireMock integration tests, retry tests that depended on WireMock stubs, and the related JSON scenario files).The resulting
coresources are identical to the outcome of thejava17template commit for the shared files; the extra files touched here (CI.md,pom_OSSRH_NOTINUSE.xmlfiles) are references that only exist onmaster.Users who need HTTP mocking can keep using WireMock directly via its own DSL, as noted in the issue.
Checklist:
1. New Unit tests were added
2. Integration tests were added
3. Test names are meaningful
3.1 Feature manually tested and outcome is successful
4. PR doesn't break any of the earlier features for end users
Note: users mocking endpoints through Zerocode's WireMock wrapper will need to use WireMock directly via its own DSL (this is the intent of #783). Virtuoso mock strategy is unaffected.
5. PR doesn't break the HTML report features directly
/targetfolder and they look fine6. PR doesn't break any HTML report features indirectly
mvn clean testrun after removal: interactive HTML report, granular HTML report and CSV all generated incore/targetwith the complete test results and zero WireMock references)7. Branch build passed in CI
8. No 'package.*' in the imports
9. Relevant DOcumentation page added or updated with clear instructions and examples for the end user
10. Http test added to
http-testing-examplesmodule(if applicable) ?11. Kafka test added to
kafka-testing-examplesmodule(if applicable) ?