Skip to content

ISSUE-783 # Remove WireMock feature (dependency, code, tests)#785

Open
devmaiter wants to merge 1 commit into
authorjapps:masterfrom
devmaiter:issue-783-remove-wiremock
Open

ISSUE-783 # Remove WireMock feature (dependency, code, tests)#785
devmaiter wants to merge 1 commit into
authorjapps:masterfrom
devmaiter:issue-783-remove-wiremock

Conversation

@devmaiter

Copy link
Copy Markdown

Remove WireMock feature (dependency, code, tests)

Fixed Which Issue?

PR Branch
https://github.com/devmaiter/zerocode/tree/issue-783-remove-wiremock

Motivation and Context

As discussed in #783, this removes the WireMock integration (Maven dependency, code paths, tests and fixtures) from master, mirroring what was already done on the java17 branch (commit 51120fb, PR #752) but excluding the Java 17-specific changes.

Scope of the removal:

  • pom.xml (root), core/pom.xml, junit5-testing-examples/pom.xml: com.github.tomakehurst:wiremock dependency and wiremock.version property removed. Same cleanup applied to the pom_OSSRH_NOTINUSE.xml files and the WireMock mention in CI.md.
  • RestEndPointMocker: WireMock code paths removed (the Virtuoso mock strategy is untouched).
  • HttpApiExecutorImpl, MockStep, ZeroCodeMultiStepsScenarioRunnerImpl: WireMock branches removed.
  • HandlebarsLocalDateHelper, ZeroCodeWireMockRunner and all WireMock-only tests/fixtures deleted (RestEndPointMockerTest, MockStepTest, WireMock integration tests, retry tests that depended on WireMock stubs, and the related JSON scenario files).

The resulting core sources are identical to the outcome of the java17 template commit for the shared files; the extra files touched here (CI.md, pom_OSSRH_NOTINUSE.xml files) are references that only exist on master.

Users who need HTTP mocking can keep using WireMock directly via its own DSL, as noted in the issue.

Checklist:

  • 1. New Unit tests were added

    • 1.1 Covered in existing Unit tests (removal-only change; full existing suite passes)
  • 2. Integration tests were added

    • 2.1 Covered in existing Integration tests
  • 3. Test names are meaningful

  • 3.1 Feature manually tested and outcome is successful

  • 4. PR doesn't break any of the earlier features for end users

    • 4.1 WARNING! This might break one or more earlier earlier features, hence left a comment tagging all reviewrs

Note: users mocking endpoints through Zerocode's WireMock wrapper will need to use WireMock directly via its own DSL (this is the intent of #783). Virtuoso mock strategy is unaffected.

  • 5. PR doesn't break the HTML report features directly

    • 5.1 Yes! I've manually run it locally and seen the HTML reports are generated perfectly fine
    • 5.2 Yes! I've opened the generated HTML reports from the /target folder and they look fine
  • 6. PR doesn't break any HTML report features indirectly

    • 6.1 I have not added or amended any dependencies in this PR (a dependency was removed, see 6.2)
    • 6.2 I have double checked, the new dependency added or removed has not affected the report generation indirectly (full mvn clean test run after removal: interactive HTML report, granular HTML report and CSV all generated in core/target with the complete test results and zero WireMock references)
    • 6.3 The generated HTML report has the same structure/branding as before the change (report generation code was not touched by this PR).
  • 7. Branch build passed in CI

  • 8. No 'package.*' in the imports

  • 9. Relevant DOcumentation page added or updated with clear instructions and examples for the end user

    • 9.1 Not applicable. This was only a code refactor change, no functional or behaviourial changes were introduced
  • 10. Http test added to http-testing-examples module(if applicable) ?

    • 10.1 Not applicable. The changes did not affect HTTP automation flow
  • 11. Kafka test added to kafka-testing-examples module(if applicable) ?

    • 11.1 Not applicable. The changes did not affect Kafka automation flow

@authorjapps

Copy link
Copy Markdown
Owner

@devmaiter , CI build is in-progress here, let's have a look for the Green status, then review and merge the PR(785).

@nirmalchandra

Copy link
Copy Markdown
Collaborator

@devmaiter , CI build is in-progress here, let's have a look for the Green status, then review and merge the PR(785).

Got a red 🔴 build and given a rerun. Can you keep an eye ?

@devmaiter

Copy link
Copy Markdown
Author

Thanks for the rerun! The build is green now — all 5 Java matrix builds passed on attempt 3. Looks like the red was a transient failure. Ready for review whenever you are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove WireMock feature (dependency, code, tests)

3 participants