Skip to content

ISS-492 added support for yaml as step file#505

Merged
nirmalchandra merged 5 commits into
authorjapps:masterfrom
imBharatMalviya:ISS-492-YAML-STEP-FILE
Dec 7, 2022
Merged

ISS-492 added support for yaml as step file#505
nirmalchandra merged 5 commits into
authorjapps:masterfrom
imBharatMalviya:ISS-492-YAML-STEP-FILE

Conversation

@imBharatMalviya

@imBharatMalviya imBharatMalviya commented Nov 9, 2021

Copy link
Copy Markdown
Collaborator

ISSUE-492 added support for yaml as step file

This is a PR in response to #492

Checklist:

  • Unit tests added

  • Integration tests added

  • Test names are meaningful

  • Feature manually tested

  • Branch build passed

  • No 'package.*' in the imports

  • Relevant Wiki page updated with clear instruction for the end user

    • Not applicable. This was only a refactor change, no functional or behaviour changes were introduced
  • Http test added to http-testing module(if applicable) ?

    • Not applicable. The changes did not affect HTTP automation flow
  • Kafka test added to kafka-testing module(if applicable) ?

    • Not applicable. The changes did not affect Kafka automation flow

@M3lkior M3lkior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @imBharatMalviya thanks for the PR ; can you rebase your branch and view the PR review ?

Comment thread core/src/test/resources/unit_test_files/yaml/scenario_get_api_step_test.yml Outdated
imBharatMalviya and others added 4 commits November 17, 2022 20:24
…CodeValueTokens.java

Co-authored-by: Ludovic Dussart <ludovic.dussart.pro@gmail.com>
…step_test.yml

Co-authored-by: Ludovic Dussart <ludovic.dussart.pro@gmail.com>

@M3lkior M3lkior left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nirmalchandra

Copy link
Copy Markdown
Collaborator

Hello @imBharatMalviya , will get this merged and released soon.
Can you please create a Wiki page and add an example of this YAML step-reuse please?
Let me know in case you don't have enough permission, I will get this created for you 👍

Just checking, is this urgent or can this wait till mid Jan due to Xmas holidays?

@nirmalchandra
nirmalchandra merged commit 455f633 into authorjapps:master Dec 7, 2022
@imBharatMalviya

Copy link
Copy Markdown
Collaborator Author

Hello @imBharatMalviya , will get this merged and released soon. Can you please create a Wiki page and add an example of this YAML step-reuse please? Let me know in case you don't have enough permission, I will get this created for you 👍

Just checking, is this urgent or can this wait till mid Jan due to Xmas holidays?

Hey @nirmalchandra

Apologies for the very late reply here somewhere along the way "mid-Jan" turned into a few years.

Confirming I don't have write access to the wiki, so if you could create the page (or grant me permission), I'll get the content in right away it's ready to go.

@authorjapps

Copy link
Copy Markdown
Owner

**imBharatMalviya **

Hey, here is the Collab link to join, you shd have the write access once joined.
Let me know if it still doesnt work

@imBharatMalviya

Copy link
Copy Markdown
Collaborator Author

Got write access, thanks! Pushed the wiki page: https://github.com/authorjapps/zerocode/wiki/External-YAML-file-as-reusable-content

Also linked it in the sidebar. Let me know if you want any changes.

@nirmalchandra

Copy link
Copy Markdown
Collaborator

Got write access, thanks! Pushed the wiki page: https://github.com/authorjapps/zerocode/wiki/External-YAML-file-as-reusable-content

Also linked it in the sidebar. Let me know if you want any changes.

Amazing work @imBharatMalviya !
Is it possible to make this page available in the doc site as well here -> https://zerocode-tdd.tddfy.com/ ?
Here are the steps to follow and raise PR.

Just duplicate this page(you just wrote) there.

@imBharatMalviya

Copy link
Copy Markdown
Collaborator Author

Got write access, thanks! Pushed the wiki page: https://github.com/authorjapps/zerocode/wiki/External-YAML-file-as-reusable-content
Also linked it in the sidebar. Let me know if you want any changes.

Amazing work @imBharatMalviya ! Is it possible to make this page available in the doc site as well here -> https://zerocode-tdd.tddfy.com/ ? Here are the steps to follow and raise PR.

Just duplicate this page(you just wrote) there.

Thanks! I copied the page. Could you please grant me access to this repo as well so I can create the PR?

@authorjapps

Copy link
Copy Markdown
Owner

**imBharatMalviya **

@imBharatMalviya,
Added you now as collaborator here (click to join)

@imBharatMalviya

Copy link
Copy Markdown
Collaborator Author

Done! I've duplicated the page in the docs site and raised the PR: authorjapps/zerocode-tdd-docs#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is it possible to add YAML.FILE as a Value token?

4 participants