chore: dead code removal and helper deduplication - #26
Merged
Conversation
- Drop CSS for the demo-credentials login panel removed in the production-hardening work - Hoist the scenario wizard tab order into a single EDITOR_TABS constant (was declared four times, twice within one function) - Extract csvQuote helper shared by the two CSV exports - Extract eachProgramme helper for the four programme-directory scans in server.js (also gives the auth helpers consistent skip-and-log handling of unreadable files via readJsonSafe) - Remove unused runState.startTime and debriefState.timerRunning - Ignore .claude/ local assistant settings; declare the Node engine range package.json already advertises in the README badge No behaviour change. QA suite passes (37/37). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codebase cleanup with no behaviour change:
EDITOR_TABSconstant), the CSV quote helper (2 copies), and the programme-directory scan in server.js (4 copies →eachProgramme, which also standardises skip-and-log handling of unreadable files)runState.startTime,debriefState.timerRunning).gitignorenow covers.claude/; package.json declares theenginesrange the README badge advertisesTesting
🤖 Generated with Claude Code