This repository was archived by the owner on Jun 4, 2025. It is now read-only.
chore: add explicit callCounts.set to avoid future inconvenience - #49
Open
joseluisdiaz wants to merge 1 commit into
Open
chore: add explicit callCounts.set to avoid future inconvenience#49joseluisdiaz wants to merge 1 commit into
joseluisdiaz wants to merge 1 commit into
Conversation
joseluisdiaz
marked this pull request as ready for review
November 2, 2023 20:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has no direct impact on how things work because the cache is returning a reference to the object that is being stored. Modifying that object will cause the object in the cache to go through the modification. This explicit set prevents the reader from thinking that it's missing some how.