Open
Conversation
For write fault we only need to touch a single register for fault_advance, to not do a full write, introduce a regs_size argument to fault_advance_vcpu and pass it to seL4_TCB_WriteRegisters. The actual optimization depends on this commit in seL4: seL4/seL4@19a520a Signed-off-by: Yifei Zhan <yifei@zhan.science>
Collaborator
|
@ZhanYF do you have any numbers to indicate how much the optimisation helps? |
Contributor
Author
The worst case is 50 cycles reduction on fault handling on odroidc4, my previous tests showed about 300 cycles but I can no longer reliably reproduce it. Terry mentioned there is a throughput increase of 120Mb/s -> 131Mb/s for virtio. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For write fault we only need to touch a single register for fault_advance, to not do a full write, introduce a regs_size argument to fault_advance_vcpu and pass it to seL4_TCB_WriteRegisters.
The actual optimization depends on this commit in seL4: seL4/seL4@19a520a