docs(saa-js): document turnReady event payload field types (#22)#43
Open
MunawarJohar wants to merge 1 commit into
Open
docs(saa-js): document turnReady event payload field types (#22)#43MunawarJohar wants to merge 1 commit into
MunawarJohar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
Problem
The README listed the
turnReadypayload shape ({ audioBase64, audioPcm16, durationSec, frames, context }) with no types ordescriptions, and was missing the
serverTurnReadyTsMsfield entirely.Consumers had to read the SDK source to know field types.
Fix
serverTurnReadyTsMsto the Events table payload summary.turnReadyfields table directly below the Events table,documenting type and description for every field, verified against
the
emit("turnReady", ...)call site inclient.ts'shandleServerMessage().Documentation only — no code changes.