fix(dev): eliminate startup friction for new contributors#59
Merged
Conversation
…red tsconfig, warn on production NODE_ENV during setup - packages/api/package.json: dev script now sets NODE_ENV=development so the API no longer crashes when the user's shell has NODE_ENV=production. The rate limiter requires Redis in production mode; local dev should never need Redis. - packages/shared/tsconfig.json: switch from commonjs/node to NodeNext/ NodeNext. Removes the TypeScript 5.x deprecation warning about commonjs with ES2022 target, and aligns with the package's existing conditional exports. - scripts/setup.mjs: add checkNodeEnv() that warns if NODE_ENV=production is detected during setup, and suggests unsetting it. Step count bumped from 8 to 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A fresh clone + setup run by an external agent hit three avoidable friction points:
Changes
Verification
Risk
Low. The shared package already declares conditional `exports`; NodeNext is the correct resolution strategy for it. The API dev script change only affects the `dev` target, not `build` or `start`.