fix: resolve verification issues from Round 1 remediation#55
Merged
Conversation
- Fix P1-ERR-08: Astro adapter err→error rename in packages/adapters/astro/src/index.ts:105 - Fix P2-LINT-01: Add .js extensions to CLI test imports (6 files) - Fix P2-LINT-02: Extract useUserPreferencesSafe to avoid conditional hook call in DarkModeContext.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues discovered in the Round 1 verification report:
P1-ERR-08: Astro adapter
err→errorrename (blocker)packages/adapters/astro/src/index.ts:105catch (error)block referenced${err}instead of${error}, causing a TypeScript compilation error${err}→${error}P2-LINT-01: CLI test imports need
.jsextensionspackages/cli/src/commands/__tests__/.jsextension for ESM (TS2835).jsto all relative imports (e.g.../auth→../auth.js)P2-LINT-02: Web lint — conditional hook call
packages/web/src/contexts/DarkModeContext.tsx:24useUserPreferenceswas called inside atryblock at the top level of the component body, which ESLint flagged as a conditional hook calluseUserPreferencesSafecustom hook so the hook call is unconditional at the component levelVerification
npm run build -w @ori/sharednpm run type-check -w @ori/apinpm run build:check -w @ori/webnpm run lint --workspacesnpm run test -w @ori/apinpm run test -w @ori/web