Skip to content

fix: resolve verification issues from Round 1 remediation#55

Merged
atlanticplatformgroup merged 1 commit into
mainfrom
fix/verification-issues
May 27, 2026
Merged

fix: resolve verification issues from Round 1 remediation#55
atlanticplatformgroup merged 1 commit into
mainfrom
fix/verification-issues

Conversation

@atlanticplatformgroup
Copy link
Copy Markdown
Owner

Summary

Fixes three issues discovered in the Round 1 verification report:

P1-ERR-08: Astro adapter errerror rename (blocker)

  • File: packages/adapters/astro/src/index.ts:105
  • Problem: catch (error) block referenced ${err} instead of ${error}, causing a TypeScript compilation error
  • Fix: Changed ${err}${error}

P2-LINT-01: CLI test imports need .js extensions

  • Files: 6 test files in packages/cli/src/commands/__tests__/
  • Problem: Relative imports missing .js extension for ESM (TS2835)
  • Fix: Added .js to all relative imports (e.g. ../auth../auth.js)

P2-LINT-02: Web lint — conditional hook call

  • File: packages/web/src/contexts/DarkModeContext.tsx:24
  • Problem: useUserPreferences was called inside a try block at the top level of the component body, which ESLint flagged as a conditional hook call
  • Fix: Extracted the try/catch into a dedicated useUserPreferencesSafe custom hook so the hook call is unconditional at the component level

Verification

Check Result
npm run build -w @ori/shared ✅ PASS
npm run type-check -w @ori/api ✅ PASS
npm run build:check -w @ori/web ✅ PASS
npm run lint --workspaces ✅ PASS (0 errors, only pre-existing warnings)
npm run test -w @ori/api 🟡 52 pre-existing failures (rate-limit/auth middleware tests need DB)
npm run test -w @ori/web 🟡 378 pre-existing failures (React act() in production build — known issue)

- Fix P1-ERR-08: Astro adapter err→error rename in packages/adapters/astro/src/index.ts:105
- Fix P2-LINT-01: Add .js extensions to CLI test imports (6 files)
- Fix P2-LINT-02: Extract useUserPreferencesSafe to avoid conditional hook call in DarkModeContext.tsx
@atlanticplatformgroup atlanticplatformgroup merged commit d5d2733 into main May 27, 2026
1 check failed
@atlanticplatformgroup atlanticplatformgroup deleted the fix/verification-issues branch May 27, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant