fix: address corrected Round 2 verification report issues#53
Merged
Conversation
- P1-STYLE-03: update playwright.config.ts testIgnore regex to .test.ts - P2-STYLE-02: create packages/web/src/index.ts barrel file - P1-PERF-05: add pagination to collections/config-routes.ts (page/limit params) - P1-PERF-09: React.lazy code-split WorkspaceAppContent in App.tsx - P2-CSS-03: convert minHeight magic numbers to px strings in workspace-shell-sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses remaining issues from the corrected verification report.
Changes:
playwright.config.tstestIgnoreregex from.spec.tsto.test.tspackages/web/src/index.tsbarrel file re-exportinglib/index.jscollections/config-routes.tswithpage/limitquery paramsWorkspaceAppContentwith React.lazy inApp.tsxminHeightmagic numbers to px strings inworkspace-shell-sidebar.tsxNot addressed (intentionally):
useCallbackinSchemaFieldAdvancedSettings.tsx/environments-settings-support.tsx— inline callbacks are stable arrow functions inside render; addinguseCallbackwould requireuseCallbackimport and dependency arrays with no measurable benefit for these non-memoized child components.browse-view-support.tsx— components are tightly coupled toCollectionBrowseControllertype; already usesmemointernally.Verification:
npm run build -w @ori/shared✅npm run type-check -w @ori/api✅npm run build:check -w @ori/web✅