fix: use basename(workspace) instead of repoName for workspaceFolder#126
Open
sdiazbarraza wants to merge 2 commits into
Open
fix: use basename(workspace) instead of repoName for workspaceFolder#126sdiazbarraza wants to merge 2 commits into
sdiazbarraza wants to merge 2 commits into
Conversation
The override config was setting workspaceFolder to /workspaces/{repoName} instead of /workspaces/{basename(workspace)}, causing container exec to fail when branch folder name differs from repo name (e.g. feature/login vs carro-smart)
Adds a test case that verifies basename(workspace) is used for workspaceFolder and container name, taking precedence over the repoName parameter when both are provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basename(workspace)instead ofrepoNameforworkspaceFolderand containernameingenerateOverrideConfigbasename(workspace)takes precedence overrepoNamewhen both are providedChanges
Fix (config.js)
Test (config.test.js)
basename(workspace)forworkspaceFolderprefers basename(workspace) over repoName when both providedTesting
Checklist
npm test)