test: add integration tests for optimize --output=overwrite (fixes #1933)#2173
Open
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Open
test: add integration tests for optimize --output=overwrite (fixes #1933)#2173gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Conversation
gavin913427-hash
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: da9e237 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing integration test coverage for the
asyncapi optimizecommand when using the--output=overwriteflag with--no-tty(fixes #1933)Changes
Added two new test cases to
test/integration/optimize.test.ts:YAML overwrite test: Copies an unoptimized YAML fixture to a temp file, runs
optimize --no-tty --output=overwrite, verifies:asyncapi: 2.0.0)JSON overwrite test: Same flow with a JSON fixture, verifying JSON output format is preserved after overwrite
Why this matters
The
--output=overwritepath was previously untested, meaning regressions in file-overwriting behavior could go undetected.Related issue(s)
Fixes #1933
Checklist
--output=overwritewith YAML input--output=overwritewith JSON input