test: add validation middleware tests (fixes #2019)#2170
Open
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Open
test: add validation middleware tests (fixes #2019)#2170gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Conversation
Add tests for validation middleware covering: - Condition-based pass-through - Unsupported path handling - Request body validation - Invalid body rejection - Document array handling Improves test coverage for lib/apps/api/middlewares/validation.middleware.ts Fixes asyncapi#2019
gavin913427-hash
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add tests for validation middleware to improve test coverage.
Why
The validation middleware (lib/apps/api/middlewares/validation.middleware.ts) had low test coverage. Many error-handling branches and async flows were not exercised.
How
Changes
test/unit/middlewares/validation.middleware.test.tsFixes #2019