fix: handle circular references in diff command gracefully (fixes #2093)#2167
Open
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Open
fix: handle circular references in diff command gracefully (fixes #2093)#2167gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Conversation
When AsyncAPI documents contain circular $ref references, the diff command now catches the error and provides a clear message instead of crashing with an unhelpful TypeError. The error message guides users to resolve circular references before running the diff command. Fixes asyncapi#2093
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Handle circular references in the diff command gracefully instead of crashing.
Why
When AsyncAPI documents contain circular
$refreferences, thejson()method on parsed documents throws aTypeErrorwith a message about circular structures. The diff command didn't handle this case, resulting in an unhelpful error for users.How
json()callsChanges
src/apps/cli/commands/diff.tsTesting
Fixes #2093