fix: limit diagnostics-format options to actually supported formats (fixes #2007)#2164
Open
gavin913427-hash wants to merge 1 commit intoasyncapi:masterfrom
Open
Conversation
The help message showed 12 formats but only 7 were actually supported. The unsupported formats (github-actions, sarif, code-climate, gitlab, markdown) would silently fall back to 'stylish' format. Now the help message correctly shows only the 7 supported formats: stylish, json, junit, html, text, teamcity, pretty. Fixes asyncapi#2007
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Limit
--diagnostics-formatoptions to only the actually supported formats.Why
The help message showed 12 formats but only 7 were actually supported. The unsupported formats (
github-actions,sarif,code-climate,gitlab,markdown) would silently fall back tostylishformat, which was confusing for users.How
diagnostics-formatflag options fromObject.values(OutputFormat)to a hardcoded list of the 7 supported formatsOutputFormatimportChanges
src/apps/cli/internal/flags/parser.flags.tsTesting
Fixes #2007