fix: skip metrics submission after fatal generation failure (fixes #2010)#2161
Open
gavin913427-hash wants to merge 2 commits intoasyncapi:masterfrom
Open
fix: skip metrics submission after fatal generation failure (fixes #2010)#2161gavin913427-hash wants to merge 2 commits intoasyncapi:masterfrom
gavin913427-hash wants to merge 2 commits intoasyncapi:masterfrom
Conversation
When a generation fails with a fatal error, the CLI was still attempting to submit anonymous metrics, which resulted in additional unrelated errors being printed. Now metrics are only submitted when there's no error (success case). Fixes asyncapi#2010
🦋 Changeset detectedLatest commit: 3af957a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Skip anonymous metrics submission after a fatal generation failure.
Why
When a generation fails with a fatal error (e.g., non-empty output directory), the CLI was still attempting to submit anonymous metrics in the
finally()method. This resulted in additional unrelated errors being printed, which polluted the output and confused users.How
finally()method in the base command to only submit metrics when there's no errorChanges
src/apps/cli/internal/base.tsfinally()when error is presentTesting
Fixes #2010