fix: add empty args definition to versions command (fixes #2021)#2160
Open
gavin913427-hash wants to merge 3 commits intoasyncapi:masterfrom
Open
fix: add empty args definition to versions command (fixes #2021)#2160gavin913427-hash wants to merge 3 commits intoasyncapi:masterfrom
gavin913427-hash wants to merge 3 commits intoasyncapi:masterfrom
Conversation
The versions command was missing the static args definition, which caused oclif to emit UnparsedCommand warnings during test runs. Fixes asyncapi#2021
gavin913427-hash
requested review from
AayushSaini101,
Amzani,
Shurtu-gal,
Souvikns and
asyncapi-bot-eve
as code owners
🦋 Changeset detectedLatest commit: 943b1ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gavin913427-hash
force-pushed
the
fix/unparsed-command-warnings
branch
from
2be77d5 to
b3ddae7
Compare
Fixes typescript:S1444 - Make this public static property readonly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add empty
argsdefinition to theversionscommand to preventUnparsedCommandwarnings during test runs.Why
The
versionscommand was missing thestatic argsdefinition, which caused oclif to emitUnparsedCommandwarnings during test runs. This is a common pattern in oclif commands - all commands should have explicitargsdefinitions even if they don't accept arguments.How
static args = {};to theVersionscommand classChanges
src/apps/cli/commands/config/versions.tsstatic args = {}definitionTesting
Fixes #2021