feat: add auto parallelism mode#1257
Open
MilesCranmerBot wants to merge 1 commit into
Open
Conversation
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Member
|
@MilesCranmerBot I think this is the wrong location, it should be done in the Julia side. PySR should just forward the parallelism mode but not have any moving pieces. Please close + make a SR.jl PR instead + make a PySR PR to update compatibility with the backend change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1018.
Adds
parallelism="auto"while keeping the constructor default asNonefor backward-compatible signatures/get_params behavior.Nonenow resolves like auto:deterministic=True-> serialprocsorcluster_managerset -> multiprocessingExplicit
serial,multithreading,multiprocessing, and deprecatedmultithreading=behavior are preserved.Validation:
uv run --python /usr/bin/python3.12 --extra dev pytest pysr/test/test_main.py::TestHelpMessages::test_parallelism_auto -qpysr/sr.pyare coveredgit diff --checkpassed