chore/tn-12 by IzioDev · Pull Request #3 · aspectron/khost

IzioDev · 2026-01-05T22:10:23Z

work in pair with: aspectron/kaspa-resolver#5

add testnet-12 with config
make network either supported or deprecated (testnet-11), only allow deprecated network interactions if it's to disable them
once disabled (and systemd service not running), deprecated network are removed from the local khost config file
add a small warning at startup to inform the usage of deprecated network

I initially didn't want to mess with deprecated network (mostly because impact is a bit wide), but it seemed wrong to stop systemd service on behalf of user operator

IzioDev · 2026-02-09T09:01:29Z

New branch name is covpp-reset1

aspect · 2026-02-09T09:59:45Z

@IzioDev why don’t you install VirtualBox with Ubuntu. That would be a proper environment for testing, other than a cheap VM at hetzner.

aspect · 2026-02-09T10:06:14Z

The problem is the branch name. “covpp” is “some branch”. If another branch appears then we will need to 1) republish khost 2) ask everyone to upgrade

vs anyone running khost and it detecting new latest commit hash.

so there needs to be an official “tn12” branch that would be pulled into whenever tn12 is updated.

also kaspa-resolver needs to be updated before that to support tn12.

I saw someone talking about resetting tn12 when sufficient updates come in and thus I think it will be better to hold off. (we do have to ping many ppl to run updates).

@IzioDev

IzioDev · 2026-02-09T11:51:00Z

The problem is the branch name. “covpp” is “some branch”. If another branch appears then we will need to 1) republish khost 2) ask everyone to upgrade

vs anyone running khost and it detecting new latest commit hash.

so there needs to be an official “tn12” branch that would be pulled into whenever tn12 is updated.

also kaspa-resolver needs to be updated before that to support tn12.

I saw someone talking about resetting tn12 when sufficient updates come in and thus I think it will be better to hold off. (we do have to ping many ppl to run updates).

@IzioDev

There already is a PR on the resolver: aspectron/kaspa-resolver#5

tn-12 just got reset for information, that's why I posted a comment here.

About having a dedicated branch for tn-12, I'll start the discussion.

demisrael · 2026-05-02T11:20:40Z

Thanks for the PR! Built and ran clippy on the branch — both clean. A few findings to flag before merge:

1. Port collision in src/kaspad.rs (likely a typo)

Network::Mainnet   => (16110, 17110, 18110),
Network::Testnet10 => (16210, 17210, 18210),
Network::Testnet12 => (16311, 17210, 18210),

wrpc_borsh and wrpc_json for tn-12 are identical to tn-10's, so kaspad will fail to bind if both networks are enabled at once. The previous tn-11 entry was (16310, 17310, 18310), so (16312, 17312, 18312) looks like the intended pattern. The 16311 grpc port also seems to mix the new "12" with the old "11" suffix.

2. No config migration for existing testnet11 entries

CONFIG_VERSION is still 2, and Config::load() only handles v1→v2 (omega→pnn-v1). Existing users with a config.json containing a "testnet11" kaspad entry will get a serde error on startup, since the variant was renamed (#[serde(rename_all = "lowercase")] makes the JSON tag testnet11 → testnet12). Bumping to v3 with a migration that rewrites testnet11 → testnet12 (and flips the origin to covpp for that entry) would keep upgrades smooth.

3. .gitignore adds .khost-data but the code uses .khost

folders.rs defines DATA_FOLDER_NAME = ".khost" (Linux) / 00-khost-dev (other). .khost-data doesn't match either — looks like a stray from local Docker testing.

4. Minor: redundant clone in config.rs

let selected_origin = match network { … };
kaspad::Config::new(selected_origin.clone(), network)

The match arms already produce owned Origin values, so the trailing .clone() is unnecessary.

Verified to compile cleanly on:

Linux: Ubuntu 24.04 LTS, kernel 6.8.0 x86_64, rustc/cargo 1.95.0
macOS: 15.6.1, Darwin 24.6.0 arm64, rustc/cargo 1.81.0

…nore - src/kaspad.rs: tn-12 wrpc-borsh/json ports collided with tn-10 (17210/18210). Use (16312, 17312, 18312) following the netsuffix-numbered pattern. - Use the official `tn12` branch on kaspanet/rusty-kaspa (the `covpp` branch has been removed). Rename Preset::Covpp -> Preset::Tn12 in src/git.rs for consistency. - src/config.rs: drop redundant `.clone()` on selected_origin (match arms already produce owned values). - .gitignore: remove `.khost-data` — code uses `.khost` / `00-khost-dev` per folders.rs.

IzioDev · 2026-05-04T12:06:08Z

Thanks for the good review and test @demisrael, on it.

IzioDev · 2026-05-04T12:06:37Z

Oh I just saw you impl fixes, thanks! ❤️

fix tn-12 branch + ports, drop redundant clone, remove .khost-data ignore

* wip * wip: legacy network handling * wip * wip * wip * wip --------- Co-authored-by: IzioDev <9900846+IzioDev@users.noreply.github.com>

biryukovmaxim · 2026-05-06T14:17:29Z

        Preset::PNNv1 => {
            Origin::try_new("https://github.com/aspectron/rusty-kaspa", Some("pnn-v1"))?
        }


shouldnt we add master here too?

as discussed, rolled back to aspectron origins: roll back origins to aspectron/*

biryukovmaxim · 2026-05-06T14:18:30Z

+            Supported(Testnet12) => (16312, 17312, 18312),
+            Deprecated(Testnet11) => (16311, 17311, 18311),


are these correct ports? looks non canonical

difficulty is that on kaspad, we use same default ports for tn11 and tn12 (tn11 support has been removed).

khost can have its own independent default ports, they are opaque to clients (because of nginx reverse-proxy).

what ports would you suggest to set here?

tn11 can keep 310. tn12 probably 410

done: review: update ports

IzioDev added 2 commits January 5, 2026 22:32

chore(tn-12): add tn-12 support

e34fe35

chore: support testnet-12

850a0f2

demisrael mentioned this pull request May 2, 2026

fix tn-12 branch + ports, drop redundant clone, remove .khost-data ignore IzioDev/khost#1

Merged

IzioDev and others added 3 commits May 4, 2026 14:06

Merge pull request #1 from demisrael/chore/tn-12-fixes

d117ecb

fix tn-12 branch + ports, drop redundant clone, remove .khost-data ignore

chore: config v3 migration

b023055

* wip * wip: legacy network handling * wip * wip * wip * wip --------- Co-authored-by: IzioDev <9900846+IzioDev@users.noreply.github.com>

revert: change resolver revision back to aspectron

bcd34eb

IzioDev mentioned this pull request May 5, 2026

chore: add tn-12 aspectron/kaspa-resolver#5

Merged

clippy

f828cff

biryukovmaxim requested changes May 6, 2026

View reviewed changes

IzioDev commented May 6, 2026

View reviewed changes

Comment thread src/git.rs Outdated

IzioDev added 5 commits May 6, 2026 16:59

roll back origins to aspectron/*

17ca8da

review: update ports

7789bcc

docs: clarify origin section

8174655

ci: fix install cargo nextest

13e8eec

ci: warn only if no tests

6c8cb31

biryukovmaxim merged commit 9194eb1 into aspectron:master May 6, 2026
3 checks passed

		Supported(Testnet12) => (16312, 17312, 18312),
		Deprecated(Testnet11) => (16311, 17311, 18311),

Conversation

IzioDev commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IzioDev commented Feb 9, 2026

Uh oh!

aspect commented Feb 9, 2026

Uh oh!

aspect commented Feb 9, 2026

Uh oh!

IzioDev commented Feb 9, 2026

Uh oh!

demisrael commented May 2, 2026

Uh oh!

IzioDev commented May 4, 2026

Uh oh!

IzioDev commented May 4, 2026

Uh oh!

biryukovmaxim May 6, 2026

Choose a reason for hiding this comment

Uh oh!

IzioDev May 6, 2026

Choose a reason for hiding this comment

Uh oh!

biryukovmaxim May 6, 2026

Choose a reason for hiding this comment

Uh oh!

IzioDev May 6, 2026

Choose a reason for hiding this comment

Uh oh!

biryukovmaxim May 6, 2026

Choose a reason for hiding this comment

Uh oh!

IzioDev May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

IzioDev commented Jan 5, 2026 •

edited

Loading