Add compatibility with the #[auto_impl] macro#686
Merged
Conversation
Kranzes
force-pushed
the
automock-auto_impl-compat
branch
from
June 18, 2026 15:19
4003434 to
120a88c
Compare
asomers
previously approved these changes
Jun 21, 2026
asomers
left a comment
asomers
left a comment
Owner
There was a problem hiding this comment.
This looks great! Thanks for your contribution.
Owner
|
The CI failure should be resolved by a rebase. |
Kranzes
force-pushed
the
automock-auto_impl-compat
branch
from
June 21, 2026 21:45
90c069e to
88d59b5
Compare
Contributor
Author
|
Done, please create a release after so I can pull this change from crates.io. |
asomers
dismissed
their stale review
June 21, 2026 22:39
Why aren't workflows running? Maybe dismissing my review will jog github's logic.
Owner
|
Github's AI says that workflows aren't running because "Most likely conclusion: this is a GitHub-side trigger problem for that PR update". @Kranzes could you please force-push to job the triggers? FTR, I'm annoyed that I have to use Github's CI just to tell me that Github has a bug. |
Contributor
Author
|
GHA strikes again 😂 |
`#[automock]` was copying the trait-only `#[auto_impl]` attribute onto the
generated mock, where it can't apply ("expected `trait`"). Strip it like
the other trait-only attributes so the two compose on one trait.
Kranzes
force-pushed
the
automock-auto_impl-compat
branch
from
June 22, 2026 10:21
88d59b5 to
d3b041d
Compare
asomers
approved these changes
Jun 22, 2026
asomers
left a comment
asomers
left a comment
Owner
There was a problem hiding this comment.
Whatever you just did "fixed" it. Workflows are running again.
Contributor
Author
|
I simply force pushed as you suggested :D |
GavBog
pushed a commit
to GavBog/snix
that referenced
this pull request
Jun 27, 2026
Requires asomers/mockall#686, which didn't end up in a release yet. We need to be a tiny bit more explicit with where the lifetime is coming from in DirectoryService::put_multiple_start() as the compiler doesn't seem to be able to infer it anymore, but that's only necessary for the trait definition, not all impls. Change-Id: I3863bf208621c5e65c044c6723705a5081fa7267 Reviewed-on: https://cl.snix.dev/c/snix/+/31414 Tested-by: besadii Autosubmit: Florian Klink <flokli@flokli.de> Reviewed-by: kenji <aks.kenji@protonmail.com>
Owner
|
@Kranzes released as 0.15.0 |
GavBog
pushed a commit
to GavBog/snix
that referenced
this pull request
Jul 12, 2026
asomers/mockall#686, fixing compatibility with the auto_impl macro ended in the latest release, so no more need to pin a git revision here. Change-Id: Ie7b491fb97b102176930d031c6cbc361440a1966 Reviewed-on: https://cl.snix.dev/c/snix/+/31454 Autosubmit: Florian Klink <flokli@flokli.de> Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com> Tested-by: besadii
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[automock]was copying the trait-only#[auto_impl]attribute onto thegenerated mock, where it can't apply ("expected
trait"). Strip it likethe other trait-only attributes so the two compose on one trait.